Service scan support - #1394
Open
attiasas wants to merge 8 commits into
Open
Conversation
attiasas
added
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
Jordanh1996
reviewed
Aug 9, 2026
| // replace github.com/jfrog/build-info-go => github.com/jfrog/build-info-go dev | ||
|
|
||
| // replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go master | ||
| // orto17:missconfiguration-service |
Jordanh1996
reviewed
Aug 9, 2026
Jordanh1996
left a comment
Jordanh1996
left a comment
Contributor
There was a problem hiding this comment.
Summary goldens only cover “Not Scanned”
All summary/integration/expected_response goldens add | Services | ℹ️ Not Scanned | - |. No golden shows severity details when Services findings exist (only review-comment goldens do).
Jordanh1996
reviewed
Aug 9, 2026
| } | ||
| } | ||
|
|
||
| targetResults.ResultsStatus = results.ResultsStatus{ |
Contributor
There was a problem hiding this comment.
what about status code for services here?
Jordanh1996
reviewed
Aug 9, 2026
| } | ||
| if withSastResults { | ||
| targetResults.JasResults.JasVulnerabilities.SastScanResults = []*sarif.Run{{}} | ||
| } |
Contributor
There was a problem hiding this comment.
do we need to extend this here for services too?
Jordanh1996
reviewed
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Support scanning and reporting issues from Services (Missconfigurations) scan